theming

Working on modules has made me rethink theming.  Currently the theme tags are defined in the page code, but this is a mess with modules.  For example, if a module wants to add a tag to all posts, it needs one central place to do this instead of having to do it for every page.  Centralizing the tags for posts also makes things more consistent.  But this means we should have one set of tags for every class, and this makes things less flat.  Programming code like a.b.c would map to a theme like {block:a}{block:b}{c}{/block:b}{/block:a} .  A concrete example is {block:ThreadPosts}{block:PostAuthor}{UserName}{/block:PostAuthor}{/block:ThreadPosts} .  So this is more nesting.  We can discuss this before I do it.

We discussed this. You can ahead with this.

I did this.  We can discuss what is next.

We discussed this. You can now look into indentation.

I did the indentation.

I hate it. I understand what you are doing, but your solution puts the beauty of the output above the beauty of the source and what we should have is the opposite. The templace code looks broken, created by a sloppy programmer who didn't care about closing the tags properly. When I touch that code, my first reaction is to fix the braces and that is wrong. Why can't you just count the number of tabs till the first tag and use that as the base? This seems to work in 100% of the cases, but even if there is a case where this wouldn't work well, it is still better than what we have at this point.

lowering to priority 2 for now

We can discuss this at the next meeting.

We discussed this, back to you.

I did the changes that we discussed.

The template code looks decent now, but when I look at the HTML of my sample forum I still see wrong indentations. I don't care about that, but do you see the same on your forums?

I will fix this, but lowering to priority 2.

I changed my mind, the indentations aren't perfect but they are good enough.  So closing thread.